Fix Monaco editor custom theme colors not applied with oklch CSS variables#64281
Open
shashbha14 wants to merge 2 commits intoapache:mainfrom
Open
Fix Monaco editor custom theme colors not applied with oklch CSS variables#64281shashbha14 wants to merge 2 commits intoapache:mainfrom
shashbha14 wants to merge 2 commits intoapache:mainfrom
Conversation
shashbha14
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
boring-cyborg
bot
added
area:translations
area:UI
shashbha14
force-pushed
the
fix/monaco-theme-oklch-hex
branch
2 times, most recently
from
c65bd44 to
08d9439
Compare
shashbha14
force-pushed
the
fix/monaco-theme-oklch-hex
branch
from
08d9439 to
07ac3f9
Compare
Contributor
|
I dont think you should open new PRs to address the feedback on the previous PR. You can just the branvh with your changes as the review comments get lost. Feedback PR: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #64253
The
defineThemefunction in Monaco expects#RRGGBBhex strings. The oldcssVarToHexread backctx.fillStyleafter assignment, which in Firefox returnsrgb(...)and in Chrome returns the rawoklch(...)string, both of which are silently rejected by Monaco, resulting in the defaultvsorvs-darkthemes.Fix:
fillRectwithgetImageDatapixel extraction to correctly convert any CSS color format, including oklch values from Chakra UI.